search

sighjs / sigh

multi-process expressive build system for the web and node.js, built using baconjs observables
209 stars 12 forks source link

Pass options to node-glob, fixes #37 #38

Closed jmatsushita closed 8 years ago

jmatsushita commented 8 years ago

Let me know what you think! #37

jmatsushita commented 8 years ago

Looks like I broke the basePath option. Looking into it.

insidewhy commented 8 years ago

I see you added a couple more commits, did you fix the issue with the basePath option?

insidewhy commented 8 years ago

I think it would also be better to pass the entire options in to a second field like um globOpts: {} rather than deleting all glob plugin specific fields from the option and passing it through.

jmatsushita commented 8 years ago

Sorry for the delay here. Yes indeed I fixed the issue and I agree that a globOpts key would be much cleaner. Feel free to close this pull request which I should have started from my master anyway :)