sighjs / sigh

multi-process expressive build system for the web and node.js, built using baconjs observables

209 stars 12 forks source link

Guard against empty sourceMap, fixes #39 #40

Closed jmatsushita closed 8 years ago

jmatsushita commented 8 years ago

39

insidewhy commented 8 years ago

This change breaks two tests, maybe due to the line note I added. Pretty sure the patch is unnecessary after the latest sigh.

jmatsushita commented 8 years ago

Test now passing but with a warning on the concat plugin:

 ! could not construct identity source map for subdir/output.js
 ! Line 1: Unexpected token ILLEGAL

insidewhy commented 8 years ago

@jmatsushita Yeah that warning is annoying since it alerts the console, last night I tried to stub sigh-core's log using sinon but it didn't seem to work.

insidewhy commented 8 years ago

@jmatsushita Oh and could you squash your commits together so I can merge this. Thanks!