sighjs / sigh

multi-process expressive build system for the web and node.js, built using baconjs observables
209 stars 12 forks source link

Binary files corrupted #41

Closed jmatsushita closed 8 years ago

jmatsushita commented 8 years ago

Hi there,

Using this pipeline

  pipelines['copy'] = [
    glob({ basePath: 'source' }, '**/*.*'),
    write('dest')
  ]

With this simple tree:

source/
└── logo.png

The file is modified and can't be opened.

$ cmp source/logo.png dest/logo.png 
source/logo.png dest/logo.png differ: char 1, line 1
unlight commented 8 years ago

Use gulp-copy plugin.

insidewhy commented 8 years ago

I think the issue is here: https://github.com/sighjs/sigh-core/blob/master/src/Event.js#L33

insidewhy commented 8 years ago

Published version 0.12.16 with support for this. See the readme... added an encoding option to the glob plugin.