search

sighmon / mjml-rails

MJML + ERb/Haml/Slim view template
https://mjml.io
Other
295 stars 64 forks source link

Add mj-include support and eliminate tempfiles #100

Open drush opened 1 year ago

drush commented 1 year ago

This PR has two significant improvements:

  1. <mj-include /> is now supported. This allows it to be used in VS Code with full preview support and during runtime.
  2. Eliminated the need to write input and output tempfiles in favor of stdin/stdout to the mjml command.
sighmon commented 1 year ago

@drush Sorry about the GitHub Action failures - should be fixed on master now if you'd like to merge back into this branch.

sighmon commented 1 year ago

@drush Are you still planning on fixing the failing tests? https://github.com/sighmon/mjml-rails/actions/runs/4001787672/jobs/6869100076?pr=100

johnhuang121 commented 1 year ago

Would very much like this PR included!

sighmon commented 1 year ago

@johnhuang121 Would you like to take this PR over fixing the tests and adding it as optional via a configuration variable?

johnhuang121 commented 1 year ago

I can take a look at this, but not sure if I can take this over yet.