issues
search
sighmon
/
mjml-rails
MJML + ERb/Haml/Slim view template
https://mjml.io
Other
296
stars
64
forks
source link
Replace backtick with Open3 for parser
#30
Closed
anhtrantuan
closed
6 years ago
anhtrantuan
commented
6 years ago
Why is this necessary?
Mjml::Parse#run
swallows shell execution error by using backtick syntax. Causing failure for subsequence instructions.
What were changed?
Use
Open3.popen3
to support error raising for
Mjml::Parse#run
method.
sighmon
commented
6 years ago
@anhtrantuan Nice one! Thank you.
Why is this necessary?
Mjml::Parse#run
swallows shell execution error by using backtick syntax. Causing failure for subsequence instructions.What were changed?
Open3.popen3
to support error raising forMjml::Parse#run
method.