sighmon / mjml-rails

MJML + ERb/Haml/Slim view template

https://mjml.io

Other

300 stars 65 forks source link

Increase supported mjml binary version to 4.2. #40

Closed donni106 closed 6 years ago

donni106 commented 6 years ago

There was a new mjml release three das ago, increasing the version from 4.1.2 to 4.2.0 (https://github.com/mjmlio/mjml/releases).

With this package the binary check failed and reported:

Couldn't find the MJML 4.1. binary.. have you run $ npm install mjml?

We need a new gem version supporting the 4.2.x mjml package.

39

donni106 commented 6 years ago

Should there be more logic in setting the binary version to support different mjml version at the same time? Or is it ok for users to fix the mjml-rails gem version, if they want to use an older binary?

sighmon commented 6 years ago

Thanks for the PR - from the discussion we'll make the version check more lenient to just 4., so I'll close this, but please do keep submitting PRs in future. :-)