Closed BenMorganIO closed 3 years ago
I agree that I also found it confusing when realizing that the globally installed version will take precedence over a locally installed version of mjml
.
That might be counter intuitive and I don't see a case were it could be the desired behaviour.
@BenMorganIO Did you want to pull from master again now that @NobodysNightmare 's changes are in?
+1
I gave this a shot in #66 with some other changes which should make detection and execution of mjml binary more error prone – feel free to test it.
Currently experiencing some problems in production with email sending. The problem is that Sidekiq is calling
mjml
and it appears to sometimes not know the full path. When usingmjml
it should always call the full path so that it's/usr/local/bin/mjml
and knows exactly where to read it.Another issue is that local should always take precedence over global so that a system can upgrade without worrying about a whole machines version.