search

sighmon / mjml-rails

MJML + ERb/Haml/Slim view template
https://mjml.io
Other
296 stars 64 forks source link

Yarn bin command no longer functions as it is used in lib/mjml.rb #63

Closed liamelliott closed 3 years ago

liamelliott commented 3 years ago

Running yarn bin as used in the lib/mjml.rb file no longer returns a bin directory, but a list of available binaries. In newer versions of Yarn, you must run yarn bin mjml to get a direct path to the binary. I'll take this as a PR if nobody else is able to.

sighmon commented 3 years ago

@liamelliott That'd be great if you could, and keep it backwards compatible for older versions of yarn too.

liamelliott commented 3 years ago

@sighmon Sweet! I'll try and get on that this week sometime.

doits commented 3 years ago

I think I fixed it by using yarn run mjml when installed with yarn in #66 – I think this is the proper way to run binaries by yarn anyway and with it it should work with yarn v2, too.