`Mjml::Parser#render` suppresses errors in case of Tempfile exceptions

sighmon / mjml-rails

MJML + ERb/Haml/Slim view template

https://mjml.io

Other

295 stars 64 forks source link

`Mjml::Parser#render` suppresses errors in case of Tempfile exceptions #90

Closed der-flo closed 2 years ago

der-flo commented 2 years ago

In case of an exception in Tempfile.open the in_tmp_file in the current ensure block is nil, which lets to another exception when calling unlink. This shadows the original exception.

We encountered this issue in context of a Docker environment and fixed this via a monkey patch.

Are you interested in a pull request, ideally with a test case?

sighmon commented 2 years ago

@der-flo A PR with a test case would be excellent thanks.

der-flo commented 2 years ago

It's on my list for the coming friday. Stay tuned.