search

sighmon / mjml-rails

MJML + ERb/Haml/Slim view template
https://mjml.io
Other
295 stars 64 forks source link

Exit code in case of an error when calling the mjml binary #91

Closed der-flo closed 2 years ago

der-flo commented 2 years ago

We ran into issues when calling out to the mjml binary. Our Docker environment sometimes kills the child process because of limited memory. In the case the process fails silently. We were able to debug this with a monkey patch adding the exit code to the ParseError.

Are you interested in a pull request adding this debug information?

sighmon commented 2 years ago

@der-flo Adding debug to the ParseError sounds excellent too. Yes please.

der-flo commented 2 years ago

It's on my list for the coming friday. Stay tuned.

der-flo commented 2 years ago

Christmas is coming, I‘ll prepare this in january.