sighmon / mjml-rails

MJML + ERb/Haml/Slim view template
https://mjml.io
Other
295 stars 64 forks source link

Stop running mjml with yarn. Instead fetch the bin #98

Closed alanhala closed 1 year ago

alanhala commented 1 year ago

Instead of running the bin through yarn (yarn run mjml), it makes it work like npm which is a faster way.

andrelaszlo commented 1 year ago

This makes calling mjml ~40% faster on my machine.

sighmon commented 1 year ago

@alanhala Great thanks! Looks good to me and brings it inline with the logic in check_for_npm_mjml_binary.

I don't use yarn, so might check with @doits or @thechrisoshow who previously submitted PRs.

sighmon commented 1 year ago

Haven't heard back, so let's merge this and revert if need be.