search

sighmon / mjml-rails

MJML + ERb/Haml/Slim view template
https://mjml.io
Other
295 stars 64 forks source link

Update README.md for installing mjml globally for Rails 7.x.x with importmaps #99

Closed loqimean closed 1 year ago

sighmon commented 1 year ago

@loqimean Thanks for the PR - would you mind adding some more information with links?

loqimean commented 1 year ago

@loqimean Thanks for the PR - would you mind adding some more information with links?

Thanks, but I think no, that all what user need, it helps me and I hope can help others to have clear mind of installation MJML and using your gem. Of course, I have links like the documentation of installing packages by NPM, but I think that it isn't needed

loqimean commented 1 year ago

Btw, I think that also cool idea is to add warning that user should add MJML installation to the CI

loqimean commented 1 year ago

Would you mind moving your additions below the other npm install command so they're together?

okay

loqimean commented 1 year ago

Would you mind moving your additions below the other npm install command so they're together?

it is

jlxq0 commented 1 year ago

I think more information is needed for Rails 7 and import maps. How and what would you pin (or in general do) to make mjml-rails work in Rails 7?

sighmon commented 1 year ago

@loqimean ☝🏽Would you mind expanding on your experience?

loqimean commented 1 year ago

@loqimean ☝🏽Would you mind expanding on your experience?

yes, of course

loqimean commented 1 year ago

I think more information is needed for Rails 7 and import maps. How and what would you pin (or in general do) to make mjml-rails work in Rails 7?

Hi, so in a nutshell you should just install MJML as a global package without pinning or requiring, just do it), it is really simple thing)

jlxq0 commented 1 year ago

Hm, idk. Could make it work that way for dev. But it doesn't seem to be a proper way for production environments like on heroku.

loqimean commented 1 year ago

Hm, idk. Could make it work that way for dev. But it doesn't seem to be a proper way for production environments like on heroku.

hm, for VPS all is good, I checked it yesterday btw, but what about Heroku.., hm, I think the following link can help you with it for Heroku service: https://stackoverflow.com/a/33019204/17425539