sighupio / furyctl

furyctl is the KFD (Kubernetes Fury Distribution) lifecycle manager
https://sighup.io
Apache License 2.0
33 stars 4 forks source link

Monitoring: Patches for MinIO loaded even if it's disabled #487

Closed FedericoAntoniazzi closed 6 months ago

FedericoAntoniazzi commented 7 months ago

Hi, I'm running some tests with furyctl v0.27.4 and trying to install Mimir pointing to an external S3 endpoint but the command furyctl apply fails on loading patches for MinIO.

Here's the snippet of my furyctl.yaml file

apiVersion: kfd.sighup.io/v1alpha2
kind: KFDDistribution
metadata:
  name: demo
spec:
  distributionVersion: v1.27.3
  distribution:
    kubeconfig: kubeconfig
    modules:
      monitoring:
        type: mimir
        prometheus: {}
        mimir:
          backend: externalEndpoint
          retentionTime: 10d
          externalEndpoint:
            endpoint: minio-hot.objectstorage.svc.cluster.local:9000
            insecure: true
            bucketName: mimir
            accessKeyId: minio
            secretAccessKey: minio123

Logs

❯ furyctl apply
INFO Downloading distribution...                  
INFO Validating configuration file...             
INFO Downloading dependencies...                  
INFO Running preflight checks                     
INFO Checking that the cluster is reachable...    
INFO Cluster configuration has changed, checking for immutable violations... 
INFO Cluster configuration has changed, checking for unsupported reducers violations... 
INFO Preflight checks completed successfully      
INFO changes to the Monitoring module type have been detected. This will cause the reconfiguration or deletion of the current monitoring stack. 
INFO changes to the mimir backend have been detected. This will cause the reconfiguration of mimir and the deletion of the current minio storage, if minio was disabled 
INFO Differences found from previous cluster configuration, handling the following changes:
.spec.distribution.modules.monitoring.type: none -> mimir
.spec.distribution.modules.monitoring.mimir.backend: minio -> externalEndpoint 
INFO Running preupgrade phase...                  
INFO Preupgrade phase completed successfully      
WARNING: You are about to apply changes to the cluster configuration.
Are you sure you want to continue? Only 'yes' will be accepted to confirm.
yes
INFO Installing Kubernetes Fury Distribution...   
INFO Checking that the cluster is reachable...    
INFO Checking storage classes...                  
INFO Applying manifests...                        
ERRO error while creating cluster: error while executing distribution phase: error while executing phase: error running core distribution phase: error running pre-apply reducers: error applying manifests: error while running shell: /bin/sh sh /Users/federico/.furyctl/demo/distribution/scripts/pre-apply.sh: command failed - exit status 1
out: 
err: resource mapping not found for name: "minio-monitoring-cluster" namespace: "monitoring" from "delete-monitoring-minio-ha.yaml": no matches for kind "Probe" in version "monitoring.coreos.com/v1"
ensure CRDs are installed first
resource mapping not found for name: "minio-monitoring-rules" namespace: "monitoring" from "delete-monitoring-minio-ha.yaml": no matches for kind "PrometheusRule" in version "monitoring.coreos.com/v1"
ensure CRDs are installed first
resource mapping not found for name: "minio-monitoring" namespace: "monitoring" from "delete-monitoring-minio-ha.yaml": no matches for kind "ServiceMonitor" in version "monitoring.coreos.com/v1"
ensure CRDs are installed first