search

sighupio / permission-manager

Permission Manager is a project that brings sanity to Kubernetes RBAC and Users management, Web UI FTW
https://sighup.io/
BSD 3-Clause "New" or "Revised" License
1.31k stars 172 forks source link

Move permission templates to values #97

Closed jonahbohlmann closed 1 year ago

jonahbohlmann commented 2 years ago

Hello,

I did some changes to the helm-chart to have the possibility to push the chart to a registry.

If the chart is pushed to a registry, it should be possible to configure some permission templates in the values to deploy the templates with helm. So I modified (and renamed) the "seed.yaml" to be able to configure the templates in the values file of the chart.

We have two options (that I have in mind):

Both ways are okay, but the current give the option to remove some templates if not needed or not allowed because of company security policies.

TODO: Change the version based on the merges - it depends on which PR are merged first. At all it is not a good idea to version the helm and the application together. I recommend to have different versions to helm and application.

I look forward to your review.

Thanks, Jonah

luigibarbato commented 1 year ago

Hi @jonahbohlmann 🙋🏽‍♂️ First of all, forgive me for the delay. We are back to active development of the Permission Manager. Anyway you did a great job, thanks for the contribution 💪🏾. Since it has been a while could you resolve the conflicts? Thank you :)

jonahbohlmann commented 1 year ago

@luigibarbato love to see this project comes back. I merged the master to my branch. CI says, it is blocked, but I can't see the details. Can you check? Locally, it looks like it is working fine.

luigibarbato commented 1 year ago

@luigibarbato love to see this project comes back. I merged the master to my branch. CI says, it is blocked, but I can't see the details. Can you check? Locally, it looks like it is working fine.

Thanks 🫂. Don't worry about that, in the next PRs the current CI will be redesigned.

Good Job ✌🏽