sigma / gh.el

GitHub API library for Emacs
274 stars 74 forks source link

Pakcage cl is deprecated #109

Open santoshs opened 3 years ago

santoshs commented 3 years ago

I get this warning with native-comp emacs. But I believe this gets printed with vanilla emacs too.

Warning (comp): gh-common.el:30:13: Warning: Package cl is deprecated

also other warnings related to defmethod. Replacing cl with cl-lib and defmethod with cl-defmethod gets rid of most of the warnings expect a few which is listed below.

Compiling file ~/.emacs.d/elpa/gh-20201222.438/gh-common.el at Fri Apr 16 08:35:26 2021
gh-common.el:104:14: Warning: ‘gh-object’ is an obsolete variable (as of
    25.1); use 'gh-object instead
gh-common.el:108:22: Warning: ‘object-p’ is an obsolete function (as of 25.1);
    use ‘eieio-object-p’ instead.
gh-common.el:127:15: Warning: ‘call-next-method’ is an obsolete alias (as of
    25.1); use ‘cl-call-next-method’ instead.
gh-common.el:130:14: Warning: ‘gh-ref-object’ is an obsolete variable (as of
    25.1); use 'gh-ref-object instead
gh-common.el:146:14: Warning: ‘gh-user’ is an obsolete variable (as of 25.1);
    use 'gh-user instead
gh-common.el:153:35: Warning: ‘gh-comment’ is an obsolete variable (as of
    25.1); use 'gh-comment instead

Not an elisp expert, fixing those was not straight forward.

danielfleischer commented 2 years ago

Package is now completely broken after eieio-compat was moved to obsolete in Emacs 29 master.

colonelpanic8 commented 1 year ago

Is this not fixed by #110