search

sigma / gh.el

GitHub API library for Emacs
274 stars 74 forks source link

Why disable adding labels when creating a new issue? #67

Open lujun9972 opened 8 years ago

lujun9972 commented 8 years ago 
(defmethod gh-issues-issue-req-to-update ((req gh-issues-issue))
  (let ((assignee (oref req assignee))
        ;; (labels (oref req labels))
        (milestone (oref req milestone))
        (to-update `(("title" . ,(oref req title))
                     ("state" . ,(oref req state))
                     ("body" . ,(oref req body)))))

    ;; (when labels (nconc to-update `(("labels" . ,(oref req labels) ))))
    (when milestone
      (nconc to-update `(("milestone" . ,(oref milestone number)))))
    (when assignee
      (nconc to-update `(("assignee" . ,(oref assignee login) ))))
    to-update))

I noticed that you comemnt out those two pieces of code. But I don't know why?

vermiculus commented 7 years ago

It feels like this was a missed ;todo item. Easy fix, anyway.