search

sigma / gh.el

GitHub API library for Emacs
274 stars 74 forks source link

merging next into master #74

Closed sigma closed 8 years ago

sigma commented 8 years ago

I'm considering merging the "next" branch into "master". (one of the reasons being that it's where I'm kinda fixing the eieio-related disaster that Emacs 25 is introducing...)

A lot of work has gone into this branch, and some pretty intrusive changes took place (especially the introduction of a new response parsing structure based on https://github.com/sigma/marshal.el)

@aki2o @dgtized @IvanMalison @syohex @alexander-yakushev @nicferrier @lujun9972 you maintain packages that might be impacted by this merge. Would you mind checking if your package keeps working, and open issues/PR if things don't work as expected?

Thanks !

colonelpanic8 commented 8 years ago

Is there anything you might expect to break in particular?

sigma commented 8 years ago

@IvanMalison no, in theory that should be a drop-in replacement as the interface is preserved. But given the size of the change, I'm a little worried about what might fall through the cracks

syohex commented 8 years ago

My package helm-open-github works well with next branch of gh.el.

syl20bnr commented 8 years ago

This merge broke it for me. After the update, # r asked again for my credentials and I ended up with JSON readtable error or byte-code: Wrong type argument: listp, "https://developer.github.com/v3".

Reverting back to version gh-20160619.1751 fixed if for me.

sigma commented 8 years ago

yeah, it would seem that my changes to support emacs 25 are breaking emacs 24... sigh I guess I'll need to work a bit more on that. thanks for trying it out !

peterhadlaw commented 8 years ago

How could one go about reverting to an older version? Excuse my lack of understanding. Right now I'm using Cask and Melpa to install 'magit-gh-pulls' (which depends on this). Thank you in advance!