sigma / magit-gh-pulls

Magit plugin for dealing with GitHub pull requests
254 stars 48 forks source link

Debugger entered--Lisp error: (wrong-type-argument symbolp [eieio-class-tag--gh-pulls-request ...] #100

Closed ltsampros closed 7 years ago

ltsampros commented 7 years ago

Versions:

GNU Emacs 25.1.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1911)) of 2016-09-21

Packages:

  magit              20161017.405  dependency            A Git porcelain inside Emacs
  magit-annex        20160624.2254 installed             Control git-annex from Magit
  magit-filenotify   20151116.1540 installed             Refresh status buffer when git tree changes
  magit-gh-pulls     20161010.2345 installed             GitHub pull requests extension for Magit
  magit-tramp        20150628.1152 installed             git method for TRAMP
  magithub           20161013.2332 installed             Magit interfaces for GitHub
  gh                 20160728.1525 dependency            A GitHub library for Emacs

Reproduction steps:

  1. Just press # g on a magit buffer

Error message:

Debugger entered--Lisp error: (wrong-type-argument symbolp [eieio-class-tag--gh-pulls-request unbound unbound unbound unbound unbound unbound unbound unbound unbound unbound unbound unbound unbound unbound nil nil unbound unbound unbound unbound nil unbound unbound unbound unbound])
alexander-yakushev commented 7 years ago

Please, remove *.elc files in your .emacs.d/elpa/ directory and try again. It helped a couple of people with similar issues.

ltsampros commented 7 years ago

Followed your advice. # g crashes with this (different than previous one):

Debugger entered--Lisp error: (wrong-type-argument (or eieio-object class) nil obj)
  signal(wrong-type-argument ((or eieio-object class) nil obj))
  eieio-oref(nil :sha)
  (let* ((id (eieio-oref stub (quote :number))) (base-sha (eieio-oref (eieio-oref stub (quote :base)) (quote :sha))) (base-ref (eieio-oref (eieio-oref stub (quote :base)) (quote :ref))) (head-sha (eieio-oref (eieio-oref stub (quote :head)) (quote :sha))) (invalid (equal (eieio-oref (eieio-oref stub (quote :head)) (quote :ref)) head-sha)) (have-commits (and (>= magit-gh-pulls-pull-detail-limit i) (eql 0 (magit-git-exit-code "cat-file" "-e" base-sha)) (eql 0 (magit-git-exit-code "cat-file" "-e" head-sha)))) (applied (and have-commits (magit-git-string "branch" branch (format "--contains=%s" head-sha)))) (heading (format "[%s@%s] %s\n" (propertize (number-to-string id) (quote face) (quote magit-tag)) (if (string= base-ref branch) (propertize base-ref (quote face) (quote magit-branch-local)) base-ref) (propertize (eieio-oref stub (quote :title)) (quote face) (cond (applied (quote magit-cherry-equivalent)) (have-commits nil) (invalid (quote error)) (t (quote italic)))))) (info (list user proj id))) (cond (have-commits (let* ((section1 (progn "Constructor for objects of type `magit-section'." nil (vector ... ... info ... nil nil nil nil nil nil nil nil magit-insert-section--parent nil)))) (progn nil (or (and (memq ... cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list ... section1))) (let* ((v section1)) (aset v 6 (let ... ...)))) (let ((magit-insert-section--current section1) (magit-insert-section--parent section1) (magit-insert-section--oldroot (or magit-insert-section--oldroot ...))) (catch (quote cancel-section) (insert heading) (magit-insert-heading) (if (and have-commits ...) (progn ...)) (run-hooks (quote magit-insert-section-hook)) (magit-insert-child-count section1) (set-marker-insertion-type (progn nil ... ...) t) (let* (... ... ...) (save-excursion ... ...)) (if (eq section1 magit-root-section) (magit-section-show section1) (progn nil ... ...))) section1))) (invalid (let* ((section2 (progn "Constructor for objects of type `magit-section'." nil (vector ... ... info ... nil nil nil nil nil nil nil nil magit-insert-section--parent nil)))) (progn nil (or (and (memq ... cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list ... section2))) (let* ((v section2)) (aset v 6 (let ... ...)))) (let ((magit-insert-section--current section2) (magit-insert-section--parent section2) (magit-insert-section--oldroot (or magit-insert-section--oldroot ...))) (catch (quote cancel-section) (insert heading) (run-hooks (quote magit-insert-section-hook)) (magit-insert-child-count section2) (set-marker-insertion-type (progn nil ... ...) t) (let* (... ... ...) (save-excursion ... ...)) (if (eq section2 magit-root-section) (magit-section-show section2) (progn nil ... ...))) section2))) (t (let* ((section3 (progn "Constructor for objects of type `magit-section'." nil (vector ... ... info ... nil nil nil nil nil nil nil nil magit-insert-section--parent nil)))) (progn nil (or (and (memq ... cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list ... section3))) (let* ((v section3)) (aset v 6 (let ... ...)))) (let ((magit-insert-section--current section3) (magit-insert-section--parent section3) (magit-insert-section--oldroot (or magit-insert-section--oldroot ...))) (catch (quote cancel-section) (insert heading) (run-hooks (quote magit-insert-section-hook)) (magit-insert-child-count section3) (set-marker-insertion-type (progn nil ... ...) t) (let* (... ... ...) (save-excursion ... ...)) (if (eq section3 magit-root-section) (magit-section-show section3) (progn nil ... ...))) section3)))))
  (while --dolist-tail-- (setq stub (car --dolist-tail--)) (setq i (1+ i)) (let* ((id (eieio-oref stub (quote :number))) (base-sha (eieio-oref (eieio-oref stub (quote :base)) (quote :sha))) (base-ref (eieio-oref (eieio-oref stub (quote :base)) (quote :ref))) (head-sha (eieio-oref (eieio-oref stub (quote :head)) (quote :sha))) (invalid (equal (eieio-oref (eieio-oref stub (quote :head)) (quote :ref)) head-sha)) (have-commits (and (>= magit-gh-pulls-pull-detail-limit i) (eql 0 (magit-git-exit-code "cat-file" "-e" base-sha)) (eql 0 (magit-git-exit-code "cat-file" "-e" head-sha)))) (applied (and have-commits (magit-git-string "branch" branch (format "--contains=%s" head-sha)))) (heading (format "[%s@%s] %s\n" (propertize (number-to-string id) (quote face) (quote magit-tag)) (if (string= base-ref branch) (propertize base-ref (quote face) (quote magit-branch-local)) base-ref) (propertize (eieio-oref stub (quote :title)) (quote face) (cond (applied ...) (have-commits nil) (invalid ...) (t ...))))) (info (list user proj id))) (cond (have-commits (let* ((section1 (progn "Constructor for objects of type `magit-section'." nil ...))) (progn nil (or (and ...) (signal ... ...)) (let* (...) (aset v 6 ...))) (let ((magit-insert-section--current section1) (magit-insert-section--parent section1) (magit-insert-section--oldroot ...)) (catch (quote cancel-section) (insert heading) (magit-insert-heading) (if ... ...) (run-hooks ...) (magit-insert-child-count section1) (set-marker-insertion-type ... t) (let* ... ...) (if ... ... ...)) section1))) (invalid (let* ((section2 (progn "Constructor for objects of type `magit-section'." nil ...))) (progn nil (or (and ...) (signal ... ...)) (let* (...) (aset v 6 ...))) (let ((magit-insert-section--current section2) (magit-insert-section--parent section2) (magit-insert-section--oldroot ...)) (catch (quote cancel-section) (insert heading) (run-hooks ...) (magit-insert-child-count section2) (set-marker-insertion-type ... t) (let* ... ...) (if ... ... ...)) section2))) (t (let* ((section3 (progn "Constructor for objects of type `magit-section'." nil ...))) (progn nil (or (and ...) (signal ... ...)) (let* (...) (aset v 6 ...))) (let ((magit-insert-section--current section3) (magit-insert-section--parent section3) (magit-insert-section--oldroot ...)) (catch (quote cancel-section) (insert heading) (run-hooks ...) (magit-insert-child-count section3) (set-marker-insertion-type ... t) (let* ... ...) (if ... ... ...)) section3))))) (setq --dolist-tail-- (cdr --dolist-tail--)))
  (let ((--dolist-tail-- stubs) stub) (while --dolist-tail-- (setq stub (car --dolist-tail--)) (setq i (1+ i)) (let* ((id (eieio-oref stub (quote :number))) (base-sha (eieio-oref (eieio-oref stub (quote :base)) (quote :sha))) (base-ref (eieio-oref (eieio-oref stub (quote :base)) (quote :ref))) (head-sha (eieio-oref (eieio-oref stub (quote :head)) (quote :sha))) (invalid (equal (eieio-oref (eieio-oref stub ...) (quote :ref)) head-sha)) (have-commits (and (>= magit-gh-pulls-pull-detail-limit i) (eql 0 (magit-git-exit-code "cat-file" "-e" base-sha)) (eql 0 (magit-git-exit-code "cat-file" "-e" head-sha)))) (applied (and have-commits (magit-git-string "branch" branch (format "--contains=%s" head-sha)))) (heading (format "[%s@%s] %s\n" (propertize (number-to-string id) (quote face) (quote magit-tag)) (if (string= base-ref branch) (propertize base-ref ... ...) base-ref) (propertize (eieio-oref stub ...) (quote face) (cond ... ... ... ...)))) (info (list user proj id))) (cond (have-commits (let* ((section1 ...)) (progn nil (or ... ...) (let* ... ...)) (let (... ... ...) (catch ... ... ... ... ... ... ... ... ...) section1))) (invalid (let* ((section2 ...)) (progn nil (or ... ...) (let* ... ...)) (let (... ... ...) (catch ... ... ... ... ... ... ...) section2))) (t (let* ((section3 ...)) (progn nil (or ... ...) (let* ... ...)) (let (... ... ...) (catch ... ... ... ... ... ... ...) section3))))) (setq --dolist-tail-- (cdr --dolist-tail--))))
  (catch (quote cancel-section) (magit-insert-heading "Pull Requests:") (let ((--dolist-tail-- stubs) stub) (while --dolist-tail-- (setq stub (car --dolist-tail--)) (setq i (1+ i)) (let* ((id (eieio-oref stub (quote :number))) (base-sha (eieio-oref (eieio-oref stub ...) (quote :sha))) (base-ref (eieio-oref (eieio-oref stub ...) (quote :ref))) (head-sha (eieio-oref (eieio-oref stub ...) (quote :sha))) (invalid (equal (eieio-oref ... ...) head-sha)) (have-commits (and (>= magit-gh-pulls-pull-detail-limit i) (eql 0 ...) (eql 0 ...))) (applied (and have-commits (magit-git-string "branch" branch ...))) (heading (format "[%s@%s] %s\n" (propertize ... ... ...) (if ... ... base-ref) (propertize ... ... ...))) (info (list user proj id))) (cond (have-commits (let* (...) (progn nil ... ...) (let ... ... section1))) (invalid (let* (...) (progn nil ... ...) (let ... ... section2))) (t (let* (...) (progn nil ... ...) (let ... ... section3))))) (setq --dolist-tail-- (cdr --dolist-tail--)))) (if (not cached\?) (progn (insert (if (and (boundp (quote magit-gh-pulls-status-documentation)) magit-gh-pulls-status-documentation) magit-gh-pulls-status-documentation (format "Press `%s %s` to update the pull request list." (substitute-command-keys "\\<magit-mode-map>\\[magit-gh-pulls-popup]") (char-to-string (car ...))))) (insert "\n\n"))) (if (> (length stubs) 0) (progn (insert "\n"))) (run-hooks (quote magit-insert-section-hook)) (magit-insert-child-count section0) (set-marker-insertion-type (progn nil (or (and (memq (aref section0 0) cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list (quote magit-section) section0))) (aref section0 3)) t) (let* ((end (progn nil (or (and (memq ... cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list ... section0))) (let* ((v section0)) (aset v 5 (point-marker))))) (map (intern (format "magit-%s-section-map" (progn nil (or ... ...) (aref section0 1))))) (map (and (boundp map) (symbol-value map)))) (save-excursion (goto-char (progn nil (or (and (memq ... cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list ... section0))) (aref section0 3))) (while (< (point) end) (let ((next (or ... end))) (if (get-text-property (point) (quote magit-section)) nil (put-text-property (point) next (quote magit-section) section0) (if map (progn ...))) (goto-char next))))) (if (eq section0 magit-root-section) (magit-section-show section0) (progn nil (or (and (memq (aref (progn nil ... ...) 0) cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list (quote magit-section) (progn nil (or ... ...) (aref section0 12))))) (let* ((v (progn nil (or ... ...) (aref section0 12)))) (aset v 13 (nconc (progn nil (or ... ...) (aref ... 13)) (list section0)))))))
  (let ((magit-insert-section--current section0) (magit-insert-section--parent section0) (magit-insert-section--oldroot (or magit-insert-section--oldroot (if magit-insert-section--parent nil (prog1 magit-root-section (setq magit-root-section section0)))))) (catch (quote cancel-section) (magit-insert-heading "Pull Requests:") (let ((--dolist-tail-- stubs) stub) (while --dolist-tail-- (setq stub (car --dolist-tail--)) (setq i (1+ i)) (let* ((id (eieio-oref stub ...)) (base-sha (eieio-oref ... ...)) (base-ref (eieio-oref ... ...)) (head-sha (eieio-oref ... ...)) (invalid (equal ... head-sha)) (have-commits (and ... ... ...)) (applied (and have-commits ...)) (heading (format "[%s@%s] %s\n" ... ... ...)) (info (list user proj id))) (cond (have-commits (let* ... ... ...)) (invalid (let* ... ... ...)) (t (let* ... ... ...)))) (setq --dolist-tail-- (cdr --dolist-tail--)))) (if (not cached\?) (progn (insert (if (and (boundp ...) magit-gh-pulls-status-documentation) magit-gh-pulls-status-documentation (format "Press `%s %s` to update the pull request list." (substitute-command-keys "\\<magit-mode-map>\\[magit-gh-pulls-popup]") (char-to-string ...)))) (insert "\n\n"))) (if (> (length stubs) 0) (progn (insert "\n"))) (run-hooks (quote magit-insert-section-hook)) (magit-insert-child-count section0) (set-marker-insertion-type (progn nil (or (and (memq (aref section0 0) cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list (quote magit-section) section0))) (aref section0 3)) t) (let* ((end (progn nil (or (and ...) (signal ... ...)) (let* (...) (aset v 5 ...)))) (map (intern (format "magit-%s-section-map" (progn nil ... ...)))) (map (and (boundp map) (symbol-value map)))) (save-excursion (goto-char (progn nil (or (and ...) (signal ... ...)) (aref section0 3))) (while (< (point) end) (let ((next ...)) (if (get-text-property ... ...) nil (put-text-property ... next ... section0) (if map ...)) (goto-char next))))) (if (eq section0 magit-root-section) (magit-section-show section0) (progn nil (or (and (memq (aref ... 0) cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list (quote magit-section) (progn nil ... ...)))) (let* ((v (progn nil ... ...))) (aset v 13 (nconc (progn nil ... ...) (list section0))))))) section0)
  (let* ((section0 (progn "Constructor for objects of type `magit-section'." nil (vector (quote cl-struct-magit-section) (quote pulls) nil (point-marker) nil nil nil nil nil nil nil nil magit-insert-section--parent nil)))) (progn nil (or (and (memq (aref section0 0) cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list (quote magit-section) section0))) (let* ((v section0)) (aset v 6 (let ((value (run-hook-with-args-until-success ... section0))) (if value (eq value (quote hide)) (let (...) (if it ... nil))))))) (let ((magit-insert-section--current section0) (magit-insert-section--parent section0) (magit-insert-section--oldroot (or magit-insert-section--oldroot (if magit-insert-section--parent nil (prog1 magit-root-section (setq magit-root-section section0)))))) (catch (quote cancel-section) (magit-insert-heading "Pull Requests:") (let ((--dolist-tail-- stubs) stub) (while --dolist-tail-- (setq stub (car --dolist-tail--)) (setq i (1+ i)) (let* ((id ...) (base-sha ...) (base-ref ...) (head-sha ...) (invalid ...) (have-commits ...) (applied ...) (heading ...) (info ...)) (cond (have-commits ...) (invalid ...) (t ...))) (setq --dolist-tail-- (cdr --dolist-tail--)))) (if (not cached\?) (progn (insert (if (and ... magit-gh-pulls-status-documentation) magit-gh-pulls-status-documentation (format "Press `%s %s` to update the pull request list." ... ...))) (insert "\n\n"))) (if (> (length stubs) 0) (progn (insert "\n"))) (run-hooks (quote magit-insert-section-hook)) (magit-insert-child-count section0) (set-marker-insertion-type (progn nil (or (and (memq ... cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list ... section0))) (aref section0 3)) t) (let* ((end (progn nil (or ... ...) (let* ... ...))) (map (intern (format "magit-%s-section-map" ...))) (map (and (boundp map) (symbol-value map)))) (save-excursion (goto-char (progn nil (or ... ...) (aref section0 3))) (while (< (point) end) (let (...) (if ... nil ... ...) (goto-char next))))) (if (eq section0 magit-root-section) (magit-section-show section0) (progn nil (or (and (memq ... cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list ... ...))) (let* ((v ...)) (aset v 13 (nconc ... ...)))))) section0))
  (progn (let* ((section0 (progn "Constructor for objects of type `magit-section'." nil (vector (quote cl-struct-magit-section) (quote pulls) nil (point-marker) nil nil nil nil nil nil nil nil magit-insert-section--parent nil)))) (progn nil (or (and (memq (aref section0 0) cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list (quote magit-section) section0))) (let* ((v section0)) (aset v 6 (let ((value ...)) (if value (eq value ...) (let ... ...)))))) (let ((magit-insert-section--current section0) (magit-insert-section--parent section0) (magit-insert-section--oldroot (or magit-insert-section--oldroot (if magit-insert-section--parent nil (prog1 magit-root-section ...))))) (catch (quote cancel-section) (magit-insert-heading "Pull Requests:") (let ((--dolist-tail-- stubs) stub) (while --dolist-tail-- (setq stub (car --dolist-tail--)) (setq i (1+ i)) (let* (... ... ... ... ... ... ... ... ...) (cond ... ... ...)) (setq --dolist-tail-- (cdr --dolist-tail--)))) (if (not cached\?) (progn (insert (if ... magit-gh-pulls-status-documentation ...)) (insert "\n\n"))) (if (> (length stubs) 0) (progn (insert "\n"))) (run-hooks (quote magit-insert-section-hook)) (magit-insert-child-count section0) (set-marker-insertion-type (progn nil (or (and ...) (signal ... ...)) (aref section0 3)) t) (let* ((end (progn nil ... ...)) (map (intern ...)) (map (and ... ...))) (save-excursion (goto-char (progn nil ... ...)) (while (< ... end) (let ... ... ...)))) (if (eq section0 magit-root-section) (magit-section-show section0) (progn nil (or (and ...) (signal ... ...)) (let* (...) (aset v 13 ...))))) section0)))
  (if (or (> (length stubs) 0) (not cached\?)) (progn (let* ((section0 (progn "Constructor for objects of type `magit-section'." nil (vector (quote cl-struct-magit-section) (quote pulls) nil (point-marker) nil nil nil nil nil nil nil nil magit-insert-section--parent nil)))) (progn nil (or (and (memq (aref section0 0) cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list (quote magit-section) section0))) (let* ((v section0)) (aset v 6 (let (...) (if value ... ...))))) (let ((magit-insert-section--current section0) (magit-insert-section--parent section0) (magit-insert-section--oldroot (or magit-insert-section--oldroot (if magit-insert-section--parent nil ...)))) (catch (quote cancel-section) (magit-insert-heading "Pull Requests:") (let ((--dolist-tail-- stubs) stub) (while --dolist-tail-- (setq stub ...) (setq i ...) (let* ... ...) (setq --dolist-tail-- ...))) (if (not cached\?) (progn (insert ...) (insert "\n\n"))) (if (> (length stubs) 0) (progn (insert "\n"))) (run-hooks (quote magit-insert-section-hook)) (magit-insert-child-count section0) (set-marker-insertion-type (progn nil (or ... ...) (aref section0 3)) t) (let* ((end ...) (map ...) (map ...)) (save-excursion (goto-char ...) (while ... ...))) (if (eq section0 magit-root-section) (magit-section-show section0) (progn nil (or ... ...) (let* ... ...)))) section0))))
  (let* ((api (magit-gh-pulls-get-api)) (user (car repo)) (proj (cdr repo)) (cached\? (magit-gh-pulls-requests-cached-p api user proj)) (stubs (if cached\? (progn (funcall magit-gh-pulls-maybe-filter-pulls (eieio-oref (gh-pulls-list api user proj) (quote :data)))))) (num-total-stubs (length stubs)) (i 0) (branch (magit-get-current-branch))) (if (or (> (length stubs) 0) (not cached\?)) (progn (let* ((section0 (progn "Constructor for objects of type `magit-section'." nil (vector ... ... nil ... nil nil nil nil nil nil nil nil magit-insert-section--parent nil)))) (progn nil (or (and (memq ... cl-struct-magit-section-tags)) (signal (quote wrong-type-argument) (list ... section0))) (let* ((v section0)) (aset v 6 (let ... ...)))) (let ((magit-insert-section--current section0) (magit-insert-section--parent section0) (magit-insert-section--oldroot (or magit-insert-section--oldroot ...))) (catch (quote cancel-section) (magit-insert-heading "Pull Requests:") (let (... stub) (while --dolist-tail-- ... ... ... ...)) (if (not cached\?) (progn ... ...)) (if (> ... 0) (progn ...)) (run-hooks (quote magit-insert-section-hook)) (magit-insert-child-count section0) (set-marker-insertion-type (progn nil ... ...) t) (let* (... ... ...) (save-excursion ... ...)) (if (eq section0 magit-root-section) (magit-section-show section0) (progn nil ... ...))) section0)))))
  (progn (let* ((api (magit-gh-pulls-get-api)) (user (car repo)) (proj (cdr repo)) (cached\? (magit-gh-pulls-requests-cached-p api user proj)) (stubs (if cached\? (progn (funcall magit-gh-pulls-maybe-filter-pulls (eieio-oref ... ...))))) (num-total-stubs (length stubs)) (i 0) (branch (magit-get-current-branch))) (if (or (> (length stubs) 0) (not cached\?)) (progn (let* ((section0 (progn "Constructor for objects of type `magit-section'." nil ...))) (progn nil (or (and ...) (signal ... ...)) (let* (...) (aset v 6 ...))) (let ((magit-insert-section--current section0) (magit-insert-section--parent section0) (magit-insert-section--oldroot ...)) (catch (quote cancel-section) (magit-insert-heading "Pull Requests:") (let ... ...) (if ... ...) (if ... ...) (run-hooks ...) (magit-insert-child-count section0) (set-marker-insertion-type ... t) (let* ... ...) (if ... ... ...)) section0))))))
  (if repo (progn (let* ((api (magit-gh-pulls-get-api)) (user (car repo)) (proj (cdr repo)) (cached\? (magit-gh-pulls-requests-cached-p api user proj)) (stubs (if cached\? (progn (funcall magit-gh-pulls-maybe-filter-pulls ...)))) (num-total-stubs (length stubs)) (i 0) (branch (magit-get-current-branch))) (if (or (> (length stubs) 0) (not cached\?)) (progn (let* ((section0 ...)) (progn nil (or ... ...) (let* ... ...)) (let (... ... ...) (catch ... ... ... ... ... ... ... ... ... ...) section0)))))))
  (let* ((repo (magit-gh-pulls-guess-repo))) (if repo (progn (let* ((api (magit-gh-pulls-get-api)) (user (car repo)) (proj (cdr repo)) (cached\? (magit-gh-pulls-requests-cached-p api user proj)) (stubs (if cached\? (progn ...))) (num-total-stubs (length stubs)) (i 0) (branch (magit-get-current-branch))) (if (or (> (length stubs) 0) (not cached\?)) (progn (let* (...) (progn nil ... ...) (let ... ... section0))))))))
  (progn (let* ((repo (magit-gh-pulls-guess-repo))) (if repo (progn (let* ((api (magit-gh-pulls-get-api)) (user (car repo)) (proj (cdr repo)) (cached\? (magit-gh-pulls-requests-cached-p api user proj)) (stubs (if cached\? ...)) (num-total-stubs (length stubs)) (i 0) (branch (magit-get-current-branch))) (if (or (> ... 0) (not cached\?)) (progn (let* ... ... ...))))))))
  (condition-case print-section (progn (let* ((repo (magit-gh-pulls-guess-repo))) (if repo (progn (let* ((api ...) (user ...) (proj ...) (cached\? ...) (stubs ...) (num-total-stubs ...) (i 0) (branch ...)) (if (or ... ...) (progn ...))))))) ((debug error) nil))
  magit-gh-pulls-insert-gh-pulls()
  run-hooks(magit-status-sections-hook)
  magit-status-refresh-buffer()
  apply(magit-status-refresh-buffer nil)
  magit-refresh-buffer()
  magit-refresh()
  (if (not (and creds (car creds) (cdr creds))) (message "Remote repository is not configured or incorrect.") (magit-gh-pulls-purge-cache) (gh-pulls-list (magit-gh-pulls-get-api) (car creds) (cdr creds)) (magit-refresh))
  (let ((creds (magit-gh-pulls-guess-repo))) (if (not (and creds (car creds) (cdr creds))) (message "Remote repository is not configured or incorrect.") (magit-gh-pulls-purge-cache) (gh-pulls-list (magit-gh-pulls-get-api) (car creds) (cdr creds)) (magit-refresh)))
  magit-gh-pulls-reload()
  funcall-interactively(magit-gh-pulls-reload)
  call-interactively(magit-gh-pulls-reload)
  magit-invoke-popup-action(103)
  funcall-interactively(magit-invoke-popup-action 103)
  call-interactively(magit-invoke-popup-action nil nil)
  command-execute(magit-invoke-popup-action)

Creating a PR though with # c crashes with:

magit-gh-pulls-create-pull-request: Symbol’s function definition is void: when-let

After adding a (require 'subr-x), # c worked successfully :)

alexander-yakushev commented 7 years ago

Did you clean the elcs for all packages? Did you restart Emacs after that? Since the error has changed, it means you are on the right track :).

ltsampros commented 7 years ago

@alexander-yakushev yes. I hadn't deleted all .elc files apart from github and magit related ones.

Thanks everything seems to work only with that minor exception of (require 'subr-x).

Thanks

alexander-yakushev commented 7 years ago

You are welcome!