search

sigma / magit-gh-pulls

Magit plugin for dealing with GitHub pull requests
254 stars 48 forks source link

Misleading keyboard shortcut displayed in status buffer #122

Open raxod502 opened 6 years ago

raxod502 commented 6 years ago

I see this in the status buffer:

Pull Requests:
Press `M-x magit-gh-pulls-popup g` to update the pull request list.

Whereas I would expect:

Pull Requests:
Press `# g` to update the pull request list.

Note that # g does work as advertised, and C-h k # shows me:

# runs the command magit-gh-pulls-popup (found in
  magit-gh-pulls-mode-map), which is an interactive compiled Lisp
  function in ‘magit-gh-pulls.el’.

It is bound to #.

(magit-gh-pulls-popup &optional ARG)

Show popup buffer featuring Github Pull Requests commands.

I assume this is because substitute-command-keys is somehow called in the wrong context.