sigma / magit-gh-pulls

Magit plugin for dealing with GitHub pull requests

254 stars 48 forks source link

Replace deprecated magit-section-value #124

Closed J3RN closed 6 years ago

J3RN commented 6 years ago

Hi there! :wave: Big fan of the project!

Problem

As of Magit 2.12.0, the function magit-section-value became obsolete. As of recently, the function no longer exists in Magit. Consequently, the functions magit-gh-section-req-data and magit-gh-pulls-open-in-browser are throwing an error for me.

Solution

As recommended by Magit, I have replaced the (magit-section-value ...) calls with (oref ... value). Works on my machine!

DanSchoppe commented 6 years ago

Thanks, @J3RN ! This fix worked for me. Let's hope it gets merged!

raxod502 commented 6 years ago

cc @sigma