sigma / magit-gh-pulls

Magit plugin for dealing with GitHub pull requests

254 stars 48 forks source link

Selecting a PR in PR list complains about missing magit-section-value symbol #131

Open c3d opened 3 years ago

c3d commented 3 years ago

Steps to reproduce:

Select a repository
Fetch the PR list
Select a PR
Hit return, apparently bound to magit-gh-pulls-fetch-commit

Expected result:

Shows the PR that was selected

Observed result

Fails with message

magit-gh-section-req-data: Symbol’s function definition is void: magit-section-value

c3d commented 3 years ago

This appears to be a problem with 0.5.3 as bundled on melpa. Checking out master and using that seems to hit different problems, but that (message Contacting host: api.github.com:443 and stuck there).

c3d commented 3 years ago

At least # o does the right thing and shows the PR in a browser.

c3d commented 3 years ago

Apparently, on some PRs, it does something sensible, which is to show the diffs. Does not exactly show the PR itself, but at least, that's no longer in the "bugs" category.

On some other PRs, it does not do anything sensible that I can tell.