search

sigma / magit-gh-pulls

Magit plugin for dealing with GitHub pull requests
254 stars 48 forks source link

Can't get magit-gh-pulls-reload to show any pull requests. #15

Closed scubacabra closed 10 years ago

scubacabra commented 10 years ago

I can't seem to get any pull requests showing with magit-gh-pulls-reload.

I tried debugging it and I didn't really get anywhere.

I can see what I think is a correct parsing from magit-gh-guess-repo as

("jacobono" . "gradle-wsdl-plugin.git")

Could it be something like the .git extension is getting in the way?

alexander-yakushev commented 10 years ago

".git" extension shouldn't be there, although the plugin usually works having it as well. Can you show your full remote URL from .git/config?

scubacabra commented 10 years ago

This is what I have in remote/origin

[remote "origin"]
        url = https://github.com/jacobono/gradle-wsdl-plugin.git
        fetch = +refs/heads/*:refs/remotes/origin/*
alexander-yakushev commented 10 years ago

OK, then can you try removing the .git at the end? Meanwhile I've pushed the patch that should handle this extension for https-protocol links as well.

scubacabra commented 10 years ago

Oh yeah! Adding your patch did the trick :)

Thanks! On Aug 29, 2014 9:30 AM, "Alexander Yakushev" notifications@github.com wrote:

OK, then can you try removing the .git at the end? Meanwhile I've pushed the patch that should handle this extension for https-protocol links as well.

— Reply to this email directly or view it on GitHub https://github.com/sigma/magit-gh-pulls/issues/15#issuecomment-53875435.

alexander-yakushev commented 10 years ago

Nice to hear that.