Open chalmagean opened 9 years ago
Do you want to remove it per project?
I want to remove it from my magit status. Not sure what you mean by per project.
There is no such possibility right now. How would you prefer to use it if it wasn't in magit-status?
What I'd really like is to easily create PRs, checkout PRs from other team memebers and see/post/answer comments. But the real problem is it's slow and it makes magit slow, that's why I'd like to remove it from magit.
Actually it should only cause visible lag during the first usage, then cache will kick in. What do you receive from running M-: (magit-gh-pulls-guess-repo)
?
I get ("OrganisationName" . "ProjectName") and the lag is pretty significant but so is the number of pull requests.
I see. Do you need all of those PRs, or can you possibly filter them? (see #19).
I don't really need all of them, I'd like to group them by author or filter those that are not mine.
So again a separate buffer for PR management is required. This is feasible but unfortunately I don't have enough time to implement that now.
Yeah I think a separate buffer would be better. It would also be nice to have a way to see/add comments.
Maybe seeing comments might be useful, but I don't think it is a good idea to turn magit-gh-pulls into a complete Github client. You can open a pull request normally in browser with # g o
, why do you need that within Emacs?
Because I don't like going to the browser that much, I preffer doing as much as possible inside the editor.
Well, anyway that's a different issue. You can create another GH issue for this and see if anyone wants to implement that.
Hi, I'm working on that (PR comments). In my job I need to review several PRs daily and it would be great if I could do all review process in emacs. I hope have something functional in few days.
With regard to turn magit-gh-pulls into a complete gh client, I have the same dilema but I don't know what is the best choice. I'm open to talk about possible solutions.
@chalmagean I'm not sure if you still use magit-gh-pulls, but the latest version (updated for magit 2.1) doesn't poll Github automatically anymore. You have to press # g g
to get the PR list for the first time. This should help the delay issues you've been having.
How do you remove the pull requests section from the magit status buffer ? It slows down magit-status.