search

sigma / magit-gh-pulls

Magit plugin for dealing with GitHub pull requests
254 stars 48 forks source link

Obsolete name arg ... to constructor ... (was: Can't fetch pull request commit) #63

Open halbtuerke opened 8 years ago

halbtuerke commented 8 years ago

I can't fetch pull request commits. I'm trying to pull https://github.com/halbtuerke/encourage-mode.el/pull/2 but it always errors with the following:

128 git … fetch patch-2
fatal: 'patch-2' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

GNU Emacs 25.0.50.1 (x86_64-apple-darwin15.0.0, NS appkit-1404.13 Version 10.11.1 (Build 15B42)) of 2015-11-27

magit-gh-pulls 20151118.811

Configured URL: git@github.com:halbtuerke/encourage-mode.el.git

Let me know if you need more information.

halbtuerke commented 8 years ago

Somehow it's now working, and other than restarting Emacs a couple of times in between yesterday and now, I have no clue what's different.

The only little annoyance are these messages:

.emacs.d/elpa/magit-gh-pulls-20151118.811/magit-gh-pulls.el: Obsolete name arg "api" to constructor gh-pulls-api
.emacs.d/elpa/magit-gh-pulls-20151118.811/magit-gh-pulls.el: Obsolete name arg "cache" to constructor gh-cache [2 times]
vermiculus commented 7 years ago

This is probably sigma/gh.el#91