search

sigma / magit-gh-pulls

Magit plugin for dealing with GitHub pull requests
254 stars 48 forks source link

Support for Github's PR templates and better pull request editor #87

Open danielmartin opened 8 years ago

danielmartin commented 8 years ago

I'm currently working on extending this software to support Github's PR template system. It works perfectly, but I've noticed that the default pull request editor basically extends text-mode. I think we should include some basic markdown features in magit-gh-pulls-editor-mode, or extend from markdown-mode, but this means adding another dependency.

What do you think is the best approach?

willmcclellan commented 7 years ago

Related to this, I can see that PR Template support is there, but github also supports PR templates under a .github/ folder in the root. Is it easy enough to add that support to the plugin? We can always shift our templates to the root for compatibility https://github.com/blog/2111-issue-and-pull-request-templates

danielmartin commented 7 years ago

@willmcclellan I've created a PR to support the .github/ folder for PR templates: https://github.com/sigma/magit-gh-pulls/pull/94

alexander-yakushev commented 7 years ago

I've just merged #94.

I think we should include some basic markdown features in magit-gh-pulls-editor-mode, or extend from markdown-mode

This is a great idea! I've made the editor-mode a minor mode, and now conditionally enable markdown-mode if it is installed. If it is not, regular text-mode is used. Please, give it a try!