Make branch: magit-gh-pulls-create-branch

sigma / magit-gh-pulls

Magit plugin for dealing with GitHub pull requests

254 stars 48 forks source link

Make branch: magit-gh-pulls-create-branch #89

Open bobot opened 8 years ago

bobot commented 8 years ago

Perhaps I don't understand the goal of Make branch, but I think it is very strange that it asks for a base branch and that it merge the commit of the PR in this branch. I would expect at the end of Make branch to have exactly the same tip commit than the one on github.

For that, I see two possibilities: 1) the merge :sha should be replaced by a reset --hard :sha 2) directly git checkout branch :sha, that remove the need for asking for a base branch.

raxod502 commented 6 years ago

@sigma I just ran into this. Has there been any update here? It seems like the current functionality directly contradicts the description of # b in the README:

create a topic branch for this PR. After testing the PR you can merge it back into your branch using Magit.