search

sigma / magit-gh-pulls

Magit plugin for dealing with GitHub pull requests
254 stars 48 forks source link

Stop excluding branches when creating PRs #91

Closed jowl closed 8 years ago

jowl commented 8 years ago

Maybe I've misunderstood how this is supposed to work, but I found it weird that it wasn't possible to select the currently checked out branch as either base or head when creating a PR.

I'm fairly confident that I'm missing something here, but if I try to create a PR for a branch foo while having it checked out, it wasn't available in the list of branches. If I choose origin/foo from the same list, it just says that the branch isn't pushed.

alexander-yakushev commented 8 years ago

You are right. Strangely enough, the old code suggests me the current branch. I can understand why (because we are providing the current branch as the last option), but then it's weird why it doesn't work for you. Anyway, this is clearly a bug. Thank you!

jowl commented 8 years ago

Much appreciated, and thank you for a nice extension!