search

sigma0-dev / zkbitcoin

zkBitcoin: zero-knowledge proofs on Bitcoin!
MIT License
163 stars 32 forks source link

Split project into multiple crates #34

Open ppoliani opened 9 months ago

ppoliani commented 9 months ago

We've had this discussion here already https://github.com/sigma0-xyz/zkbitcoin/pull/24. With the addition of version checks I realized that it makes sense to split the crates for the purpose of proper versioning.

Changes to the admin cli are independent from the user cli tool. Thus we would need to keep different versions and having a single crate does not help.

ppoliani commented 8 months ago

@mimoo do you think we can re-open https://github.com/sigma0-xyz/zkbitcoin/pull/24?

mimoo commented 8 months ago

I think before that would happen we would need to move the code that's in the CLI to the internal functions (I haven't had the time to clean up the code I added within the CLI commands that really don't belong there :D)

if you're interested in tackling this feel free to push a PR! Otherwise I'll try to find some time this week end

ppoliani commented 8 months ago

I just checked the commits. I believe you've done some work around this, right?

mimoo commented 8 months ago

we discussed with @imikushin and agreed to postpone this as it's not urgent work, but I agree that we should tackle this at some point