sigma67 / spotify_to_ytmusic

Clone a Spotify playlist to YouTube Music
MIT License
791 stars 65 forks source link

Create single script for batch transfers, refactor Setup.py and Youtube.py #9

Closed PattoMotto closed 2 years ago

PattoMotto commented 3 years ago
sigma67 commented 3 years ago

Looks like some useful changes at first glance, although a bit difficult to compare since so many things were changed.

Is it backwards compatible with existing setups?

PattoMotto commented 3 years ago

@sigma67 I upgraded the Setup script.

Before python Setup.py musicmanager After python Setup.py --musicmanager OR python Setup.py -mm

Before python Setup.py mobileclient After python Setup.py --mobileclient OR python Setup.py -mc

Before python Setup.py youtube After python Setup.py --youtube OR python Setup.py -yt

And the new headers_raw python Setup.py --youtube --headers_raw "HEADERS"

Please let me know if you've any concerns with this upgrade.

sigma67 commented 3 years ago

Yes, but that's not all you changed. There's also many changes to YouTube.py. You also didn't answer my question about backwards compatibility.

PattoMotto commented 3 years ago

There's also many changes to YouTube.py. You also didn't answer my question about backwards compatibility.

YouTube.py will be 100% backward compatible. I just moved YTMusicTransfer to another file and modify the main method argument getter. Which still work when you call YouTube.py directly.

lucasrangit commented 3 years ago

@PattoMotto , @sigma67 I can try and tease out some of these changes into smaller commits if either of you don't have time. I see some useful changes and improvements.

sigma67 commented 3 years ago

For sure, the main thing that prevented me from looking at it was the size of the change and I wasn't sure if it was compatible with my own app branch

PattoMotto commented 3 years ago

@lucasrangit Thanks :)