search

sigma67 / spotify_to_ytmusic

Clone a Spotify playlist to YouTube Music
MIT License
949 stars 72 forks source link

OAuth setup question potentially does not have any input checking #96

Closed alexmdev04 closed 5 months ago

alexmdev04 commented 6 months ago

During setup, when asked Use OAuth method for authorization to transfer private playlists (yes/no): If you respond with anything other than yes or no (e.g. y) it will accept the answer but will always error with ValueError: Not a boolean: y

sigma67 commented 6 months ago

Yes. It states what you're supposed to answer. Are you surprised you're getting an error if you answer something different?

alexmdev04 commented 6 months ago

Okay there's no need to be rude I'm just pointing out that users usually expect a level of input sanitation to prevent this kind of thing from happening, clearly you aren't interested in doing this which is completely fine for a small single purpose free tool, however if you ever develop anything with a broader user base I would recommend using input sanitation to prevent complaints and save yourself the headache of dealing with users. 👍

sigma67 commented 6 months ago

I didn't write that code, it's by @webns

I also didn't say I'm not open to changing it. Feel free to submit a PR