sigma67 / ytmusicapi

Unofficial API for YouTube Music
https://ytmusicapi.readthedocs.io
MIT License
1.71k stars 194 forks source link

Remove offset + fix top result #517

Closed AustinGitHub closed 8 months ago

AustinGitHub commented 8 months ago

Issue - https://github.com/sigma67/ytmusicapi/issues/518 These offsets cause an issue

Fix, I test this way image

Before BeforeChange.txt

After AfterChanges.txt

Differences image

Only issue is this

image

But this is because code forced in to append None for artist without Id but then again, what if an artist name is "Album" can't just filter that out by keyword. I think this append of None should be taken out because with the way youtube music and youtube topic channels are auto-created I think it is safe to say most artists would have an id, no?

Let me know and I can commit that change, thanks!

AustinGitHub commented 8 months ago

Tried to run the pyTests but it's very complicated. The oauth works fine, but the browser one just says paste the request headers from firefox and press enter, but what request headers? I am confused on that part.

Also, can't you write a new script to run both of those functions and then move the file as well? Would make it a lot easier.

jcbirdwell commented 8 months ago

but what request headers?

Request headers come from a post request to a user specific endpoint. So with your network monitor open navigate from something like home -> library and use the post request associated with it.

AustinGitHub commented 8 months ago

Thanks!