sigma67 / ytmusicapi

Unofficial API for YouTube Music
https://ytmusicapi.readthedocs.io
MIT License
1.71k stars 194 forks source link

fix #544 #560

Closed sigma67 closed 6 months ago

sigma67 commented 7 months ago

closes #544

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 96.42857% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.92%. Comparing base (90d172b) to head (2c3ef94).

Files Patch % Lines
ytmusicapi/parsers/albums.py 94.44% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #560 +/- ## ========================================== + Coverage 95.78% 95.92% +0.13% ========================================== Files 36 36 Lines 2136 2157 +21 ========================================== + Hits 2046 2069 +23 + Misses 90 88 -2 ``` | [Flag](https://app.codecov.io/gh/sigma67/ytmusicapi/pull/560/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sigma67) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/sigma67/ytmusicapi/pull/560/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sigma67) | `95.92% <96.42%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sigma67#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

heisen273 commented 6 months ago

hey, i have same keyerror in get_playlist() method._.

Screenshot 2024-03-09 at 21 45 42

response structure(sorry for screenshot, it's too big to paste in here): Screenshot 2024-03-09 at 21 47 28

after spending some time on this, i've found that this

results = nav(response, TWO_COLUMN_RENDERER + ["secondaryContents"] + SECTION_LIST_ITEM + ["musicPlaylistShelfRenderer"])

fixes the issue, but then other logics(own_playlist var, ...) breaks._. hope this helps at least somehow. pls let me know if i should share full raw response payload with you.

sigma67 commented 6 months ago

Yes, please share. Also share a screenshot of that playlist

Please do so in a separate issue