sigma67 / ytmusicapi

Unofficial API for YouTube Music
https://ytmusicapi.readthedocs.io
MIT License
1.59k stars 182 forks source link

fix #562 #573

Closed sigma67 closed 2 months ago

sigma67 commented 3 months ago

closes #562

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.88%. Comparing base (2217f3d) to head (79a1186). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #573 +/- ## ========================================== - Coverage 95.92% 95.88% -0.04% ========================================== Files 36 36 Lines 2183 2187 +4 ========================================== + Hits 2094 2097 +3 - Misses 89 90 +1 ``` | [Flag](https://app.codecov.io/gh/sigma67/ytmusicapi/pull/573/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sigma67) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/sigma67/ytmusicapi/pull/573/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sigma67) | `95.88% <100.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sigma67#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hundredfire commented 2 months ago

Hello! Looks like there are errors due to the test procedure? Is there anything we can help with? Thank you for your work btw

sigma67 commented 2 months ago

Hi @hundredfire , thanks for the offer.

I'm mainly missing more test data for different playlists. I'm interested in playlists where the header (the metadata part) looks different, i.e. the order of the data changes. See #562 for some example screenshots

Currently we have tests for owned playlists and foreign playlists, so if you could provide some additional response data for those that would be great