Closed czifumasa closed 1 day ago
Could you please add appropriate tests that fail without your changes and pass with them?
Attention: Patch coverage is 92.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 93.53%. Comparing base (
05cb3ca
) to head (4207444
).
Files | Patch % | Lines |
---|---|---|
ytmusicapi/parsers/playlists.py | 92.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixed invalid playlist item info for collaborative playlists from #603 issue. Instead of hardcoded indexes for flexColumns, now they are resolved using their navigationEndpoint with following logic:
watchEndpoint
-> titlebrowseEndpoint
withpageType == MUSIC_PAGE_TYPE_ALBUM
-> albumbrowseEndpoint
withpageType == MUSIC_PAGE_TYPE_ARTIST
(Regular Artists) orpageType == MUSIC_PAGE_TYPE_UNKNOWN
(Artists for uploaded songs)-> artistsbrowseEndpoint
withpageType == MUSIC_PAGE_TYPE_USER_CHANNEL
-> user channelAdditional checks:
Unavailable songs do not have navigationEndpoints so hardcoded indexes are still used. Collaborative user is not listed for unavailable song, so it should not be a problem.