Open heinrich26 opened 1 month ago
Attention: Patch coverage is 97.61905%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 94.99%. Comparing base (
2b5d19a
) to head (a8a1f5f
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
ytmusicapi/mixins/browsing.py | 92.85% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Yea, calling the API "as a different frontend" gives you different results. I temporarily changed the client because I thought unforeseen side-effects aren't desirable.As per the implementation of a multipurpose get_lyrics()
, I would add an argument like timestamps=True/False
, to keep it backwards compatible and allow the user to always get the same (old) format – with my approach, you'll end up with 2 possible formats.Furthermore, would you keep the original format with the nested CueRange
or would you rather have a flat dict? I think that nesting is kinda useless.
finally used pre-commit to fix those formatting complaints 🤷♂️
Added
get_lyrics_with_timestamps
to get lyrics with timestamps. The Method doesn't try to parse the response as normal lyrics, if no lyrics with timestamps are returned. (could be changed to do so tho, the format is the same)