sigmaSd / IRust

Cross Platform Rust Repl
https://crates.io/crates/irust
MIT License
609 stars 34 forks source link

Use `rustyline` or `reedline` for input? #104

Open light4 opened 1 year ago

light4 commented 1 year ago

https://crates.io/crates/rustyline https://crates.io/crates/reedline

sigmaSd commented 1 year ago

I think realistically using one of those 2 is the correct move, it will get rid of like 40% of the code and all the awkwardness in the code-base.

It was fun writing stuff from scratch but I think using a readline crate would make irust better

rustyline is solid but its maintained by a single person, reedline probably is what we want and it uses crossterm internally

The problem is reedline compared to rustyline has this limitation https://github.com/crossterm-rs/crossterm/issues/396 but there is a pr filed for this , so I think its fine