sigmaSd / Stimulator

Keep your computer awake
https://flathub.org/apps/io.github.sigmasd.stimulator
MIT License
17 stars 9 forks source link

Replace ON/OFF text with symbolic power button icon #3

Closed meybonomme closed 11 months ago

meybonomme commented 11 months ago

Thank You for this simple, minimalistic and useful application!

I have suggestion: replace ON/OFF button text with the system power icon: /symbolic/actions/system-shutdown-symbolic.svg. If icon will change colour by button state, it will be very straightforward, simple and pretty solution. Plus no need to any translation, power button symbol is international.

sigmaSd commented 11 months ago

Thanks for suggestion, seems like a good idea, I'll try it out later

sigmaSd commented 11 months ago

Fixed in 0.3.7

sigmaSd commented 11 months ago
meybonomme commented 11 months ago

It looks really nice and clean! :+1:

But pure red and green does not look very good, please use libadwaita color palette for icons and background: https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/named-colors.html This will add more Gnome-ish and native look for app.

Also please remove button top rounded corners. With top rounded corners it looks little bit like a out of place. It's more noticeable with light theme:

Screenshot from 2023-12-19 10-10-56

sigmaSd commented 11 months ago

Awesome suggestions I'll definitely take a look

sigmaSd commented 11 months ago

This is what I come up with , is this good ? or do you have another suggestion for the colors ?

image image

css

.mainToggle {
  font-size: 4em;
  -gtk-icon-size: 1em;
  border-radius: 0;
  background-color: @destructive_bg_color;
  color: @destructive_fg_color;
}

.mainToggle:checked {
  background-color: @success_bg_color;
  color: @success_fg_color;
}
meybonomme commented 11 months ago

It looks very good, but I think there is too much bright colors. One reason why I love Gnome so much is its clean, minimalist and very beautiful design. So here is my suggestion, I think it matching very nice with Gnome design language:

.mainToggle {
  font-size: 4em;
  -gtk-icon-size: 1em;
  border-radius: 0;
  background-color: @window_bg_color;
  color: @destructive_bg_color;
}

.mainToggle:checked {
  background-color: @window_bg_color;
  color: @success_bg_color;
}

nosleep

meybonomme commented 11 months ago

I also added light hover effect to the button background:

.mainToggle {
  font-size: 4em;
  -gtk-icon-size: 1em;
  border-radius: 0;
  background-color: @window_bg_color;
  color: @destructive_bg_color;
  transition: 0.3s;
}

.mainToggle:checked {
  background-color: @window_bg_color;
  color: @success_bg_color;
}

.mainToggle:hover {
  background-color: @sidebar_backdrop_color;
  transition: 0.3s;
}
sigmaSd commented 11 months ago

Pr welcome! , you seem to have a good taste so I'll just leave the design decision to you

Maybe later I can make this configurable , so the user can choose different themes, it seems a lot of the new gtk4 have this kind of theme selection

meybonomme commented 11 months ago

you seem to have a good taste so I'll just leave the design decision to you

Thank You for this kind words! :slightly_smiling_face: I want to help make more useful applications look like native Gnome ones. Gnome DE is very beautiful, but it lacks consistent design language between different apps. More GTK 4/Libadwaita apps will make this situation much better.

Maybe later I can make this configurable , so the user can choose different themes, it seems a lot of the new gtk4 have this kind of theme selection

Simplicity and minimalism is one of Gnome's strong sell points, I think. There is no need to add theme selection to this tiny and very simple one button app. Let's keep things so simple and clean as possible. If there is a need to add some configuration option, this must be really useful and valuable function. This is Gnome's philosophy and I support it.

I have a idea to add "protect timer" function. Example: If I leave home for several weeks and forgot No Sleep in active state, then my laptop and external monitor are working whole this time. I think we need (configurable) timer to turn off no-idle function after some time. Gnome offers max 2 hours delay for automatic suspend, No Sleep extends this delay (by default) let's say to 5 hours. What do You think about this idea?

sigmaSd commented 11 months ago

Cool idea please open a separate issue about it so we can keep track of it there

sigmaSd commented 11 months ago

I added your code here https://github.com/sigmaSd/NoSleep/pull/6, should we go with it ?

meybonomme commented 11 months ago

I added your code here #6, should we go with it ?

Yes, I think visual changes are big enough to make another point release and push the version to 0.4.0. Let's make improvements step by step.

meybonomme commented 11 months ago

Maybe later I can make this configurable , so the user can choose different themes, it seems a lot of the new gtk4 have this kind of theme selection

Accent color support is one of most asked new Gnome's feature, I think we can discuss support for accent colors if this released sometime in future.

meybonomme commented 11 months ago

We should close this issue, because ON/OFF text is replaced and application main window is already redesigned. Let's start new issues for upcoming improvements for better to-do tracking.