search

sigmaSd / Stimulator

Keep your computer awake
https://flathub.org/apps/io.github.sigmasd.stimulator
MIT License
17 stars 9 forks source link

Reword strings to comply with GNOME HIG #70

Closed jamiethecat closed 9 months ago

sigmaSd commented 9 months ago

@meybonomme are you ok with this?

meybonomme commented 9 months ago

@meybonomme are you ok with this?

Yes, I am, except that tray icon thing. Our wording was very raw, but we can't exclude tray icon from description. Running in background doesn't mean automatically tray icon support.

jamiethecat commented 9 months ago

@meybonomme are you ok with this?

Yes, I am, except that tray icon thing. Our wording was very raw, but we can't exclude tray icon from description. Running in background doesn't mean automatically tray icon support.

I will change it for now, since changing how your app works is obviously out of scope for this MR. I do highly recommend you to use the background portal instead of tray icons though, tray icons are a hack that GNOME doesn't support for obvious reasons out of the box, while the background portal is supported in both GNOME and KDE, and it's an actual standard.

meybonomme commented 9 months ago

I will change it for now, since changing how your app works is obviously out of scope for this MR. I do highly recommend you to use the background portal instead of tray icons though, tray icons are a hack that GNOME doesn't support for obvious reasons out of the box, while the background portal is supported in both GNOME and KDE, and it's an actual standard.

We had a discussion about tray icon support, here is conclusion: https://github.com/sigmaSd/Stimulator/issues/24#issuecomment-1896122786 And this little review: https://linux.softpedia.com/get/Utilities/Stimulator-104651.shtml Quote: "Personally, I would have preferred it to offer top bar integration, and that's why I still would choose Caffeine over it."

We have background portal support (am I right @sigmaSd?) + AppIndicator support. AppIndcator is closest for tray icon standard and as far I know, GNOME is the only major DE which need "hack" for this (officially supported extension from Ubuntu community). Using AppIndicator support is not mandatory, it's optional, running in background works without it too. Plus user have option to use closing confirmation instead of running in background + AppIndicator.

Hence the idea - maybe we should separate running in background and tray icon support options, so the tray icon would be activated independently.

jamiethecat commented 9 months ago

I will change it for now, since changing how your app works is obviously out of scope for this MR. I do highly recommend you to use the background portal instead of tray icons though, tray icons are a hack that GNOME doesn't support for obvious reasons out of the box, while the background portal is supported in both GNOME and KDE, and it's an actual standard.

We had a discussion about tray icon support, here is conclusion: #24 (comment) And this little review: https://linux.softpedia.com/get/Utilities/Stimulator-104651.shtml Quote: "Personally, I would have preferred it to offer top bar integration, and that's why I still would choose Caffeine over it."

We have background portal support (am I right @sigmaSd?) + AppIndicator support. AppIndcator is closest for tray icon standard and as far I know, GNOME is the only major DE which need "hack" for this (officially supported extension from Ubuntu community). Using AppIndicator support is not mandatory, it's optional, running in background works without it too. Plus user have option to use closing confirmation instead of running in background + AppIndicator.

Hence the idea - maybe we should separate running in background and tray icon support options, so the tray icon would be activated independently.

I'd love to have this discussion somewhere else outside of an MR about rewording titles haha

meybonomme commented 9 months ago

I'd love to have this discussion somewhere else outside of an MR about rewording titles haha

Where is better place to discuss this topic?

jamiethecat commented 9 months ago

I'd love to have this discussion somewhere else outside of an MR about rewording titles haha

Where is better place to discuss this topic?

We could use the issue you linked, or talk in DMs on a platform you prefer (Discord/Matrix/Etc) :)

sigmaSd commented 9 months ago

Here is a room I just created for this https://matrix.to/#/#stimulator:matrix.org