search

sigmaSd / Stimulator

Keep your computer awake
https://flathub.org/apps/io.github.sigmasd.stimulator
MIT License
13 stars 9 forks source link

Screen reader compatibility - Image buttons have a tooltip #90

Closed meybonomme closed 7 months ago

meybonomme commented 7 months ago

Gnome Circle app criteria: https://gitlab.gnome.org/Teams/Releng/AppOrganization/-/blob/main/AppCriteria.md#accessibility

As far as I tested, we have screen reader support out of the box, but image button tooltip is missing. Fortunately we have only one image button - main menu.

Example from GNOME Files: pilt

When added, can we make this tooltip translatable? EDIT: Can answer myself - yes we can.

meybonomme commented 7 months ago

Fixed in https://github.com/sigmaSd/Stimulator/pull/91

sigmaSd commented 7 months ago

just for practicing, the issue should be kept open until the pr is merged

meybonomme commented 7 months ago

just for practicing, the issue should be kept open until the pr is merged

Thank you for guiding me on how to do things better and correctly, I am very grateful for that :+1:

meybonomme commented 7 months ago

Now is probably the right time to close issue :slightly_smiling_face: