search

sigmasternchen / minecraft-matrix-bridge

GNU Affero General Public License v3.0
8 stars 1 forks source link

Add Event handlers for PlayerDeathEvent and TimeSkipEvent #9

Closed CRTified closed 2 years ago

CRTified commented 2 years ago

This PR adds messages for both PlayerDeathEvent and TimeSkipEvent, so that the matrix-side of the bridge gets a notification when either all players went to bed or a player dies.

I think this PR is slightly opinionated, as it introduces some constant strings ("Everyone went to bed"). I don't know whether the server messages ("$Player joined/quit the game") can be configured to be non-english, so it might be unpleasant if it is the case.

sigmasternchen commented 2 years ago

I think it's fine for now.

Maybe a future improvement could be making the messages configurable. Specifically I'm thinking of "Everyone went to bed" since resource packs like "vanillatweaks" introduce multiplayer sleep.