search

sigmavirus24 / github3.py

Hi, I'm a library for interacting with GItHub's REST API in a convenient and ergonomic way. I work on Python 3.6+.
https://github3.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.21k stars 402 forks source link

add "permission" parameter to repo.add_collaborator #1101

Closed kuepe-sl closed 2 years ago

kuepe-sl commented 2 years ago

This PR adds the "permission" parameter to repo.add_collaborator, which was missing and is only valid for organisation repositories. (see here)

Fixes #954

kuepe-sl commented 2 years ago

Thanks for the hint. I will add a test case.

However I will not fix the linter error, because those are caused by the upstream main branch and not by me.

staticdev commented 2 years ago

Thanks for the hint. I will add a test case.

However I will not fix the linter error, because those are caused by the upstream main branch and not by me.

Thanks, I fixed upstream, if you rebase your PR everything should pass now.

kuepe-sl commented 2 years ago

Thanks for fixing upstream.
I rebased my commits and added a unit test.

I didn't add an integration test though, because I'm not sure how to properly execute + record that. It requires access to an Organisation and right now I only have access to private Organisation repos.

kuepe-sl commented 2 years ago

Thanks a lot for merging!

staticdev commented 2 years ago

Thank you for the PR.