search

sigmavirus24 / github3.py

Hi, I'm a library for interacting with GItHub's REST API in a convenient and ergonomic way. I work on Python 3.6+.
https://github3.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.21k stars 402 forks source link

Allow to set GitHub API version #1132

Closed anz-ableton closed 1 year ago

anz-ableton commented 1 year ago

This adds a new set_api_version method the GitHub class that accepts an API version string as defined here. The version is added to the session headers. Sessions headers remain unchanged if no version string was given.

Addresses #1121.

anz-ableton commented 1 year ago

@sigmavirus24 Should the api_version be added to the GitHub or GitHubCore class?

sigmavirus24 commented 1 year ago

@sigmavirus24 Should the api_version be added to the GitHub or GitHubCore class?

GitHub

anz-ableton commented 1 year ago

@sigmavirus24 I removed set_api_version and added an additional api_version argument to __init__ with 009961d5b874c267b6b49bc77c417dd37e7d83ba.

anz-ableton commented 1 year ago

@sigmavirus24 Are there any plans for a new release? I'm just asking because the last tag is from March last year.

sigmavirus24 commented 1 year ago

I don't have the time right now but maybe @staticdev does?

staticdev commented 1 year ago

@anz-ableton I will find some time soon.

staticdev commented 1 year ago

@sigmavirus24 can you add user static on PyPI as maintainer so I can deploy it there also?

sigmavirus24 commented 1 year ago

Resent the invite @staticdev