search

sigmavirus24 / github3.py

Hi, I'm a library for interacting with GItHub's REST API in a convenient and ergonomic way. I work on Python 3.6+.
https://github3.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.21k stars 402 forks source link

Fix issue #1137 #1139

Closed amaccormack-lumira closed 1 year ago

amaccormack-lumira commented 1 year ago

As per https://github.com/sigmavirus24/github3.py/issues/1137, github now allows pagination to get a full issue list out of the compare endpoint, so enabled pagination/iterator on the commits within the Comparison class.

Test added next to the existing test_compare_commits to check for an example with >250 commits change (250 was the previous maximum the api would return)

sigmavirus24 commented 1 year ago

Thank you @amaccormack-lumira !