PyPI artifacts use invalid filenames

[mgorny]

The PyPI artifacts for 4.0.0 violate the current version of sdist & wheel specifications by using dots in filenames:

github3.py-4.0.0.tar.gz
github3.py-4.0.0-py3-none-any.whl

However, the directory inside sdist seems to be named correctly:

$ tar -tf github3.py-4.0.0.tar.gz | head -n 1
github3_py-4.0.0/.pre-commit-config.yaml

FWIK hatchling does the correct thing so I guess the release pipeline is broken somewhere and renames the files to non-conformant filenames (but leaving the internal structure correct).

[staticdev]

@mgorny I used hatch to build and publish based on the config https://github.com/sigmavirus24/github3.py/pull/1144 If I don't do that, PyPI blocks the publish, so I do not have a clear solution for the problem for now.

[mgorny]

To be honest, I don't think there's a good solution right now, except for not using dot in project name. Good news is, to the best of my knowledge normalization treats ., _ and - as equivalent, so if you named the project e.g. github3-py this shouldn't break anything depending on it (but please don't take my word on it).

[sigmavirus24]

To be honest, I don't think there's a good solution right now, except for not using dot in project name. Good news is, to the best of my knowledge normalization treats ., _ and - as equivalent, so if you named the project e.g. github3-py this shouldn't break anything depending on it (but please don't take my word on it).

I'll go back about 10 years in time and rename it right away

[ofek]

https://github.com/sigmavirus24/github3.py/pull/1142#issuecomment-1520707331

The nonconformant/"invalid" artifact names predate the latest release:

• https://pypi.org/project/github3.py/3.2.0/#files
• https://pypi.org/project/github3.py/4.0.0/#files

[staticdev]

@mgorny we have now 4.0.1

[mgorny]

Thanks. I'll test it tomorrow early morning, if that's ok.

[mgorny]

It works fine. Thanks again!