Open caugner opened 1 year ago
Hi @sigmavirus24, could you please approve the workflows? 🙏
This won't default to None of I remember correctly. People will instead have an Attribute Error trying to access something that otherwise is there
I'm not sure I understand. Are you saying that this won't help, because people will get a different Error when accessing a property on event.actor
without checking event.actor
first? I would argue this is still better than before, because users currently cannot do anything against github3 running into this TypeError as soon as they encounter an event by a deleted user (except monkey-patching maybe).
I guess an alternative would be to initialize a GhostUser object instead, as if https://github.com/ghost was a real user.
PS: The failing Python 3.9/3.10 tests seem unrelated.
I guess an alternative would be to initialize a GhostUser object instead, as if https://github.com/ghost was a real user.
The more I think about it, the more I like the idea of a GhostUser object or a Ghost sentinel that we can return.
@caugner are you still interested in implementing a GhostUser?
Prevents the following TypeError with events of deleted users (aka "ghost"):
Fixes https://github.com/sigmavirus24/github3.py/issues/988.
Version Information
Please provide:
Minimum Reproducible Example
n/a
Exception information
n/a