sigmavirus24 / github3.py

Hi, I'm a library for interacting with GItHub's REST API in a convenient and ergonomic way. I work on Python 3.6+.
https://github3.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.21k stars 402 forks source link

chore: switch to isort from reorder python imports #1173

Closed jmeridth closed 6 months ago

jmeridth commented 6 months ago

So many files changes. "Gotta rip the bandaid off" 😄

This is a premptive strike on #1172 fix

Before opening a new issue, please search for a previously filed issue to ensure you're not creating a duplicate.

Note Bug reports without the following will receive requests for these details to be provided.

Version Information

Please provide:

Minimum Reproducible Example

Please provide an example of the code that generates the error you're seeing.

Exception information

What is exceptional about what you're seeing versus what you expected to see.

sigmavirus24 commented 6 months ago

Doesn't isort have a config for an import per line like reorder python imports?

jmeridth commented 6 months ago

That was not an issue locally:

✗ black src/github3/repos/branch.py
All done! ✨ 🍰 ✨
1 file left unchanged.

But I'll take it fixing it and now this is passing.

jmeridth commented 6 months ago

@sigmavirus24 nice change with force_single_line = true. Definitely less churn.