naive attempt to prevent exception with python 3.6

sigmf / sigmf-python

Easily interact with Signal Metadata Format (SigMF) recordings.

https://sigmf.org

GNU Lesser General Public License v3.0

44 stars 17 forks source link

naive attempt to prevent exception with python 3.6 #18

Closed gmabey closed 1 year ago

gmabey commented 1 year ago

I have no idea how hack-ish this is, but it "doesn't crash" on neither python 3.6 (rockylinux 8.8) nor python 3.10 (ubuntu 22.04) "fixes" #17

Teque5 commented 1 year ago

I think this is okay since the source code for jsonschema would seem to use the latest validator available if unspecified.

gmabey commented 1 year ago

What's the feeling around here for getting a 1.1.2 release out? (after merging this apparently-innocuous commit of course) I see that no releases have been made since the Great Divide (not a huge issue but it does present the appearance that the sigmf-python project doesn't do releases.

jacobagilbert commented 1 year ago

Happy to cut a release, lets get that hashed out on the next call. Can you make the requested change and ill merge this?

Teque5 commented 1 year ago

ready to:

tag commit?
create release?
push to pypi?

FYI if we are going to start tagging commits, then those need to be added from the oldest versions first so that they appear in order in the dropdown list. I believe we need (v0.0.1, v1.0.0, v1.0.1, and v1.1.0) to be tagged before this release.

Perhaps those tags should be deleted from the SigMF spec repo since the versions aren't strictly related (right?).