sigmf / sigmf-python

Easily interact with Signal Metadata Format (SigMF) recordings.
https://sigmf.org
GNU Lesser General Public License v3.0
42 stars 16 forks source link

Multiple Recordings in an Archive #21

Open jhazentia opened 1 year ago

jhazentia commented 1 year ago

This pull request is intended to add support for multiple recordings in archives. Fixes #11. Please let me know if you have any suggested improvements. Below is a summary of the changes:

Note that this PR does not include any changes to include a collection in archive, read collection from archive, or to update gui.py.

These changes are based on my colleagues' (Douglas Anderson @djanderson and Todd Schumann @ToddSchumann) changes: https://github.com/ntia/sigmf/tree/multi-recording-archive.

jhazentia commented 1 year ago

Also note that this fixes a bug where SigMFFile offset_and_size was ignored by archive.py

777arc commented 9 months ago

@gmabey what are your thoughts on this one?

gmabey commented 9 months ago

@gmabey what are your thoughts on this one?

Thanks for tagging me on this -- this PR had fallen off my radar, and I think I'm currently unsubcribed from changes to this project.

Teque5 commented 9 months ago

If we want this feature then I'll probably need to dive in and resolve these merge conflicts. Lately been spending free coding time on AoC.

jhazentia commented 8 months ago

@gmabey Thanks for the feedback! I plan to address your feedback, but it will probably be after the new year. Is Python 3.6 support still needed? It looks like Python 3.6 and 3.7 are end of life now.

@Teque5 I can work on the merge conflicts when I address the other feedback.

gmabey commented 8 months ago

@jhazentia yeah so the reason why the SigMF project has persisted with python 3.6 support is (only because of) RedHat 8 ... that's just the reality of many users (including me), even though it's less than ideal.