Always set core:version to 1.0.0

sigmf / sigmf-python

Easily interact with Signal Metadata Format (SigMF) recordings.

https://sigmf.org

GNU Lesser General Public License v3.0

42 stars 16 forks source link

Always set core:version to 1.0.0 #28

Closed argilo closed 11 months ago

argilo commented 11 months ago

Fixes #27.

Currently the SigMFFile and SigMFCollection constructors allow the caller to pass in core:version. The README examples, tools, and tests all set this to sigmf.__version__, which is the version number of the Python module, not the SigMF specification.

Since this module implements SigMF v1.0.0, I've modified the constructors to always set core:version to 1.0.0, ignoring any value that may have been provided by the caller.

argilo commented 11 months ago

I have assumed that 1.0.0 is the correct format, but the spec is currently ambiguous. I've proposed an clarification in https://github.com/sigmf/SigMF/pull/298.