Closed gregparkes closed 5 months ago
Awesome set of fixes!
I made a lot of mods and added some test code, but this is working how I expect now and it looks okay to merge. I'll give you a day to respond before I merge if you want to make any other changes @gregparkes.
OK @Teque5 thanks for the changes - the 'multiple globstar' is a nice touch using the + command on argparse.
There are a number of inefficiencies in terms of speed for certain edge cases:
But these are relatively small beans I'll admit.
I'm adding some slight tweaks in terms of type hints, an unused import (Path
can be removed now), and mypy spotted a naming error (using for error in validate_properties
where error
is also an imported variable).
Commit incoming.
Thanks for the PR @gregparkes!
This PR:
sigmf_validate
command.concurrent.futures
Undergone basic testing using Pytest and linting via
black
.